Resolved Virtuemart XML export problem with cf4all

But I see one major flaw that is connected to EXPORTING all the products in XML format with all the custom fields per product (they are custom fields for all)

Since I've used CSVI a year ago I set up the export really easily and tested it. It works like a charm for every field except the custom fields which show the NAME for the custom field butr not the value - the value appears as - customsforall. When I try the custom_param - I can see the values.

As you can see suddenly the param and the custom title are not nested and in a different order. Also is the re a way for me to have a seperate title and value for each field rather than having them in one line like this.

case 'custom_value':

case 'custom_price':

case 'custom_param':

case 'custom_ordering':



$titlesArray = [];

$valuesArray = [];



if ($titlesArray==[]) {

	// Get the custom title

	$query = $this->db->getQuery(true);

	$query->select($this->db->quoteName('custom_title'));

	$query->from($this->db->quoteName('#__virtuemart_customs', 'c'));

	$query->leftJoin($this->db->quoteName('#__virtuemart_product_customfields', 'f') . ' ON c.virtuemart_custom_id = f.virtuemart_custom_id');

	$query->where($this->db->quoteName('virtuemart_product_id') . ' = ' . (int) $record->virtuemart_product_id);

	$query->where($this->db->quoteName('field_type') . ' NOT IN (' . $this->db->quote('R') . ', ' . $this->db->quote('Z') . ', ' . $this->db->quote('G') . ')');



	// Check if we need to filter

	$title_filter = $this->template->get('custom_title', array(), 'array');



	if (!empty($title_filter) && $title_filter[0] !== '')

	{

		$query->where($this->db->quoteName('f.virtuemart_custom_id') . ' IN (' . implode(',', $title_filter) . ')');

	}



	$query->order(

		array(

			$this->db->quoteName('f.ordering'),

			$this->db->quoteName('f.virtuemart_custom_id')

		)

	);

	$this->db->setQuery($query);

	$titles = $this->db->loadColumn();



	if (is_array($titles))

	{

		$titlesArray = $titles;

	}

	else

	{

		//$fieldValue = '';

	}

}

// Do some field sanity check if needed

if ($fieldname !== 'custom_ordering')

{

	$fieldname = str_ireplace(array('custom_', '_param'), array('customfield_', '_params'), $fieldname);

}



if (!isset($this->customFields[$record->virtuemart_product_id][$fieldname]))

{

	if ($fieldname === 'custom_ordering')

	{

		$qfield = $this->db->quoteName('cf.ordering', 'custom_ordering');

	}

	else

	{

		$qfield = $this->db->quoteName($fieldname);

	}



	$query = $this->db->getQuery(true)

		->select($qfield)

		->select(

			$this->db->quoteName(

				array(

					'cf.virtuemart_customfield_id',

					'cf.virtuemart_custom_id',

					'cf.customfield_params',

					'c.field_type',

					'c.custom_element',

				)

			)

		)

		->from($this->db->quoteName('#__virtuemart_product_customfields', 'cf'))

		->leftJoin(

			$this->db->quoteName('#__virtuemart_customs', 'c')

			. ' ON ' . $this->db->quoteName('c.virtuemart_custom_id') . ' = ' . $this->db->quoteName('cf.virtuemart_custom_id')

		)

		->where($this->db->quoteName('cf.virtuemart_product_id') . ' = ' . (int) $record->virtuemart_product_id);



	// Check if we need to filter

	$title_filter = $this->template->get('custom_title', array());



	if (!empty($title_filter) && $title_filter[0] != '')

	{

		$query->where($this->db->quoteName('cf.virtuemart_custom_id') . ' IN (' . implode(',', $title_filter) . ')');

	}



	$query->order(

		array(

			$this->db->quoteName('cf.ordering'),

			$this->db->quoteName('cf.virtuemart_custom_id')

		)

	);

	$this->db->setQuery($query);

	$customfields = $this->db->loadObjectList();

	$this->log->add('Custom field query');



	if (!empty($customfields))

	{

		$values = array();



		foreach ($customfields as $customfield)

		{

			// Check for groups, we don't need them as they get handled automatically

			if ($customfield->field_type !== 'G')

			{

				if ($fieldname === 'customfield_params' && $customfield->field_type !== 'C')

				{

					// Fire the plugin to empty any values needed

					$result = $dispatcher->trigger(

						'exportCustomValues',

						array(

							'plugin'                    => $customfield->custom_element,

							'custom_param'              => $customfield->customfield_params,

							'virtuemart_product_id'     => $record->virtuemart_product_id,

							'virtuemart_custom_id'      => $customfield->virtuemart_custom_id,

							'virtuemart_customfield_id' => $customfield->virtuemart_customfield_id,

							'log'                       => $this->log

						)

					);



					if (is_array($result) && !empty($result))

					{

						$values = array_merge($values, $result[0]);

					}

					else

					{

						// Create the CSVI format

						// option1[value1#value2;option2[value1#value2

						$values[] = $customfield->customfield_params;

					}

				}

				else

				{

					if ($customfield->$fieldname !== false && !is_null($customfield->$fieldname))

					{

						$fieldValue = $customfield->$fieldname;



						// Apply currency formatting

						if ($fieldname === 'customfield_price')

						{

							$fieldValue = $this->formatNumber($customfield->$fieldname);

						}



						$values[] = $fieldValue;

					}

					else

					{

						$values[] = '';

					}

				}

			}

		}



		$this->customFields[$record->virtuemart_product_id][$fieldname] = $values;

		$valuesArray = $this->customFields[$record->virtuemart_product_id][$fieldname];

		

		$max = count($titlesArray) - 1;

		$counter = 0;

		

		while ($counter <= $max ){

			$fieldValue .= "<category_property>".PHP_EOL;

			$fieldValue .= "<category_property_names>".$titlesArray[$counter]."<category_property_names>".PHP_EOL;

			$fieldValue .= "<values><names>".$valuesArray[$counter]."</names></values>".PHP_EOL;

			$fieldValue .= "</category_property>".PHP_EOL;

			$fieldValue .= PHP_EOL;

			$counter++;

		}

		

		//$fieldValue = "<values><names>".implode('</names><names>', $result)."</names></values>";

		

		//$fieldValue = "<values><names>".implode('</names><names>', $this->customFields[$record->virtuemart_product_id][$fieldname])."</names></values>";

	}

	else

	{

		$fieldValue = '';

	}

}

else

{

	$fieldValue = implode('~', $this->customFields[$record->virtuemart_product_id][$fieldname]);

}



$titlesArray = [];

$valuesArray = [];

break;